Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FC-0068 docs: reference and how-tos reviewed by edunext 21 #772

Merged
merged 7 commits into from
Jan 21, 2025
Merged

FC-0068 docs: reference and how-tos reviewed by edunext 21 #772

merged 7 commits into from
Jan 21, 2025

Conversation

Apgomeznext
Copy link
Contributor

@Apgomeznext Apgomeznext commented Jan 13, 2025 •
edited
Loading

This PR modifies how-to and reference documents migrated from the legacy repositories to the educators' documentation.

@Apgomeznext
FC-0068 docs: reference and how-tos reviewed by edunext 21
a9bd7a9 
This PR modifies how-to and reference4 documents migrated from the legacy repositories to the educators' documentation.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 13, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 13, 2025 •
edited
Loading

Thanks for the pull request, @Apgomeznext!

This repository is currently maintained by @openedx/docs-openedx-org-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Apgomeznext Apgomeznext marked this pull request as ready for review January 13, 2025 23:17
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jan 15, 2025
@Apgomeznext
Copy link
Contributor Author

@sarina @jswope00, the modifications were applied to this PR. I appreciate your help.

sarina
sarina reviewed Jan 21, 2025
View reviewed changes
source/educators/references/course_development/exercise_tools/view_qualtrics_responses.rst
@@ -1,67 +1,27 @@
.. _View Qualtrics Responses:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove ALL references/files about Qualtrics, as John mentioned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the references and files about Qualtrics were erased in the PR #775 because it caused me a conflict with this PR, but it is already done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would revert all changes to this file then because otherwise there will be conflicts with #775 when we try to merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of updating the branch of #775 once we merge this PR because I still have to wait for John's approvals before merging the other PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I think merging this with these changes will make resolution harder, but I'll go ahead and merge.

@sarina sarina merged commit f9cf619 into openedx:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarina sarina sarina approved these changes

@jswope00 jswope00 Awaiting requested review from jswope00

Assignees
No one assigned
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Apgomeznext @openedx-webhooks @jswope00 @sarina @mphilbrick211